[PATCH] D93039: Introduce llvm.noalias.decl intrinsic

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:5586
+
+    // [ItCurrent, ItNext[ represents the declarations for the same scope.
+    // Ensure they are not dominating each other
----------------
asbirlea wrote:
> jeroen.dobbelaere wrote:
> > asbirlea wrote:
> > > s/[/]
> > ItCurrent inclusive, ItNext exclusive.
> > Or   [ ItCurrent, ItNext-1 ].
> > 
> Thank you for the clarification, I realized the interval from the code, but then didn't connect it to the comment notation.
> This format is new to me. I was taught the mathematical notation is `[ItCurrent, ItNext)` in this case, or, as you said, `[ItCurrent, ItNext-1]`.
@asbirlea Both are valid it seems https://en.wikipedia.org/wiki/Interval_(mathematics)#Including_or_excluding_endpoints
and https://en.wikipedia.org/wiki/ISO_31-11
I (and my children) learned the notation using only '[' and ']' ;)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93039/new/

https://reviews.llvm.org/D93039