[PATCH] D95309: [TableGen] Fix anonymous record self-reference in foreach and multiclass

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 24 08:09:28 PST 2021


Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:452
+
+    MapResolver R(Rec.get());
+    R.set(OldName, NewName);
----------------
This makes another pass over all the record fields just to resolve references to the anonymous name. Is there a way to enhance Record::resolveReferences to do this in the usual resolution pass (line 457).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95309/new/

https://reviews.llvm.org/D95309



More information about the llvm-commits mailing list