[PATCH] D95308: [TableGen] Fix instantiating multiclass in foreach

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added a comment.

I presume this change passes all the TableGen, mlir, and clang tests?



================
Comment at: llvm/lib/TableGen/TGParser.cpp:3528
+    if (resolve(MC->Entries, Substs, CurMultiClass == nullptr && Loops.empty(),
+                &NewEntries, &SubClassLoc))
       return true;
----------------
Is there a reason why we shouldn't use !CurMultiClass?


================
Comment at: llvm/test/TableGen/foreach-multiclass.td:123
+
+class G {
+  list<int> val = [10];
----------------
Could you add a comment explaining what this is testing, since it is relatively obscure?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95308/new/

https://reviews.llvm.org/D95308