[PATCH] D94426: [VPlan] Introduce VPExternalDef specialization for VPValue
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 24 06:56:53 PST 2021
fhahn added a comment.
Satish, did you see the recent changes to VPValue, which allows for easy distinction if the value is a live-in or defined in a plan? D92281 <https://reviews.llvm.org/D92281> added a `VPValue::getLiveInIRValue` member to access live-in IR values and `VPValue::getDef()` can be used to check if the value is defined inside a plan. It returns `nullptr` for live-ins. Given that, I am not sure if the extra class provides enough benefits to justify the additional complexity?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94426/new/
https://reviews.llvm.org/D94426
More information about the llvm-commits
mailing list