[PATCH] D95223: [LTO] Move DisableVerify setting to LTOCodeGenerator class (NFC).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 24 06:17:52 PST 2021
fhahn added inline comments.
================
Comment at: llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h:244
std::unique_ptr<ToolOutputFile> StatsFile = nullptr;
+ bool DisableVerify = true;
};
----------------
tejohnson wrote:
> Nit - I would say make this false by default (similar to the option in llvm-lto). While it presumably should always get set by clients, false seems like a good conservative default.
That sounds like a great idea, adjusted the default in the committed version, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95223/new/
https://reviews.llvm.org/D95223
More information about the llvm-commits
mailing list