[PATCH] D95292: [AArch64] Add vector saturating add intrinsic costs

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 24 05:21:57 PST 2021


dmgreen added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/AArch64/arith-ssat.ll:34
 ; RECIP-NEXT:  Cost Model: Found an estimated cost of 10 for instruction: %I64 = call i64 @llvm.sadd.sat.i64(i64 undef, i64 undef)
 ; RECIP-NEXT:  Cost Model: Found an estimated cost of 26 for instruction: %V2I64 = call <2 x i64> @llvm.sadd.sat.v2i64(<2 x i64> undef, <2 x i64> undef)
 ; RECIP-NEXT:  Cost Model: Found an estimated cost of 197 for instruction: %V4I64 = call <4 x i64> @llvm.sadd.sat.v4i64(<4 x i64> undef, <4 x i64> undef)
----------------
RKSimon wrote:
> I know you're just handling legal costs in this patch but these appear to be very high!
Whoops! Thanks for noticing. These should be legal, I apparently wasn't paying enough attention to how the tests changed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95292/new/

https://reviews.llvm.org/D95292



More information about the llvm-commits mailing list