[PATCH] D95136: [X86] Fix tile config register spill issue.
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 24 05:03:11 PST 2021
pengfei added inline comments.
================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:327
+ } else if (MII->isCall()) {
+ if (Call && HasAMX)
+ CfgNeedInsert.insert(Call);
----------------
LuoYuanke wrote:
> This confused me. This looks check call after amx. Should we instead check if there is amx instruction after call to determine if ldtilecfg is needed?
I moved it to AMX checking block now.
The previous code try to reduce multi insertion by puting it in the call checking block.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95136/new/
https://reviews.llvm.org/D95136
More information about the llvm-commits
mailing list