[PATCH] D95136: [X86] Fix tile config register spill issue.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:255
+    for (auto *I : LastAMXSet)
+      BuildMI(*I->getParent(), ++I->getIterator(), DebugLoc(),
+              TII->get(X86::TILERELEASE));
----------------
May add more test case for tilerelease. We may insert multi tilerelease in different block, better to have test case to cover that.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:281
+  // 0. No AMX instructions in the BB and its successors (or not sure).
+  // 1. No AMX instructions in the BB but there're in its successors.
+  // 2. There're AMX instructions in the BB but after a call instruction.
----------------
The 4 state may be a enum to be more readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95136/new/

https://reviews.llvm.org/D95136