[PATCH] D92215: [WebAssembly] MC layer writes table symbols to object files

Sat Jan 23 10:45:13 PST 2021

sbc100 added a comment.

In D92215#2517632 <https://reviews.llvm.org/D92215#2517632>, @sbc100 wrote:

> In D92215#2516547 <https://reviews.llvm.org/D92215#2516547>, @dmajor wrote:
>
>> In D92215#2506002 <https://reviews.llvm.org/D92215#2506002>, @wingo wrote:
>>
>>> Yeah as @sbc100 says, this is intended -- object files now can have table symbols, and if the compilation unit takes the address of a function or makes an indirect call, it will have a `__indirect_function_table` symbol.  So the expectations need updating; sorry for the bother!
>>
>> Looks like this `grep -v` would be a good place: https://github.com/WebAssembly/wasi-libc/blob/378fd4b21aab6d390f3a1c1817d53c422ad00a62/Makefile#L452
>>
>> I've locally changed that to `"^__mul\|^__indirect_function_table"` and it's been working fine for the past few days.
>>
>> @sbc100, I see that you're a project contributor, would you mind landing that to /wasi-libc and /wasi-sdk? I'm also happy to send a pair of PRs but I don't have my account handy this week.
>
> Yes, just send a PR when are you get a chance.   I don't think its super urgent since most wasi-libc users I think use using stable llvm releases.

Out of interest how did you notice this breakage?  Are you integrating ToT llvm with wasi-libc for a specific reason?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92215/new/

https://reviews.llvm.org/D92215