[PATCH] D95288: [ValueTracking] Don't assume readonly function will return

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 23 08:54:16 PST 2021


nikic created this revision.
nikic added reviewers: fhahn, jdoerfert.
Herald added subscribers: okura, kuter, jfb.
nikic requested review of this revision.
Herald added a reviewer: sstefan1.
Herald added a reviewer: baziotis.
Herald added subscribers: llvm-commits, bbn.
Herald added a project: LLVM.

This is similar to D94106 <https://reviews.llvm.org/D94106>, but for the isGuaranteedToTransferExecutionToSuccessor() helper. We should not assume that readonly functions will return, as this is only true for mustprogress functions (in which case we already infer willreturn). As with the DCE change, for now continue assuming that readonly intrinsics will return, as not all target intrinsics have been annotated yet.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95288

Files:
  lib/Analysis/ValueTracking.cpp
  test/Transforms/Attributor/nocapture-1.ll
  test/Transforms/Attributor/nonnull.ll
  test/Transforms/Attributor/read_write_returned_arguments_scc.ll
  test/Transforms/FunctionAttrs/nonnull.ll
  test/Transforms/GVNHoist/hoist-convergent.ll
  test/Transforms/GVNHoist/hoist-pr31891.ll
  test/Transforms/Inline/ret_attr_update.ll
  test/Transforms/JumpThreading/assume.ll
  test/Transforms/JumpThreading/guards.ll
  test/Transforms/OpenMP/parallel_deletion.ll
  unittests/Analysis/ValueTrackingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95288.318761.patch
Type: text/x-patch
Size: 23392 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210123/9deeeb9d/attachment.bin>


More information about the llvm-commits mailing list