[PATCH] D93529: [AA] Store and return estimated PartialAlias offsets.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Thanks! Diff looks reasonable to me, but I'd like to see the use case changes as well. Could you (re-)upload a concrete use case as dependent patch?
One reason I have in mind is we may want to concretely enable this caching solely for a particular BatchAA instance, i.e. pass true to BatchAA and change the meaning in AAQI from `BatchMode` to `CacheOffsets` (and, same as now, only allow BatchAA to set this bool). Then only pass true at the BatchAA callsites where it will be used.



================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:350
+  /// values. Used to optimize out redundant parts of loads/stores (in GVN/DSE).
+  /// These users cannot process quite compilcated addresses (e.g. GEPs with
+  /// non-constant offsets). Used by BatchAAResults only.
----------------
`complicated`


================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:386
+  Optional<int64_t> getClobberOffset(OffsetPair OP) const {
+    assert(BatchMode && "Clobber offset cached in batch mode inly!");
+    const bool Swapped = OP.first > OP.second;
----------------
`only`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93529/new/

https://reviews.llvm.org/D93529