[PATCH] D93497: Salvage debug info for function arguments in coro-split funclets.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl updated this revision to Diff 318715.
aprantl added a comment.

I have now uploaded a variant of the patch that incorporates logic that is similar in spirit to https://reviews.llvm.org/D94388 in that it deletes the "dead" dbg.declare intrinsics. Doing it inside of CoroFrame should be safe, since we are only deleting dbg.declares that we previously salvaged.

At least in your example, it has the desired effect. We should probably still prepare a patch that turns the artificial variables into real function parameters, but that's a separate issue.

  (lldb) v t
  (test &) t = 0x00007ffeefbff9f0 (i = 238, j = 255, k = 1)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93497/new/

https://reviews.llvm.org/D93497

Files:
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/Coroutines/CoroInternal.h
  llvm/lib/Transforms/Coroutines/CoroSplit.cpp
  llvm/test/Transforms/Coroutines/coro-debug-frame-variable.ll
  llvm/test/Transforms/Coroutines/coro-debug.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93497.318715.patch
Type: text/x-patch
Size: 12470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210123/4c02e7e9/attachment.bin>