[PATCH] D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor.
    Dan Liew via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jan 22 18:29:56 PST 2021
    
    
  
delcypher added inline comments.
================
Comment at: compiler-rt/lib/asan/asan_interceptors.cpp:228
+    // Note AsanThreadContexts never get destroyed so that still leaks.
+    t->Destroy();
   }
----------------
@vitalybuka **Is `AsanThread::Destroy()` safe to call from this thread and in this context where the corresponding thread was never started.?** I wasn't really sure. 
I see that calling this will call `DTLS_Destroy()` and I'm not sure if that needs to be called from a different thread (i.e. called from the thread before its destroyed). It looks like this function is a no-op on macOS which is where I'm testing.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95184/new/
https://reviews.llvm.org/D95184
    
    
More information about the llvm-commits
mailing list