[PATCH] D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor.
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 22 17:35:10 PST 2021
delcypher added inline comments.
================
Comment at: compiler-rt/lib/asan/asan_interceptors.cpp:224
+ result = REAL(pthread_create)(thread, attr, asan_thread_start, t);
}
return result;
----------------
delcypher wrote:
> vitalybuka wrote:
> > if (result != 0) {
> > // destroy t;
> > }
> >
> Good catch. Isn't this a separate bug though? It looks like the old code didn't handle this either. I'm happy to fix it but I think it should be in a separate patch.
Wait.. no the bug isn't the old code because I've reserved the creation order so I've introduced a new bug. I'll fix this in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95184/new/
https://reviews.llvm.org/D95184
More information about the llvm-commits
mailing list