[PATCH] D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 16:57:52 PST 2021


MaskRay added a comment.

This adds additional complexity to the logic to the linker script. The rule looks a bit arbitrary and doesn't make me feel comfortable, so I'd like to ask a few questions:

- Does this solve a category of linker script problems?
- Can you adapt your linker script to run with both GNU ld and LLD?
- If not, do you think there is some exotic part which can be changed without affecting functionality?
- If we don't support such usage, does that affect a large number of users? (Assuming they have willingness to adapt their linker scripts)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95198/new/

https://reviews.llvm.org/D95198



More information about the llvm-commits mailing list