[PATCH] D95269: [SampleFDO] Report error when reading a bad/incompatible profile instead of turning off profile use silently.

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

In D95269#2516884 <https://reviews.llvm.org/D95269#2516884>, @davidxl wrote:

> Should it be warning or error?

A build command has samplefdo flag in place, but it cannot perform the samplefdo optimization because the input profile cannot be read properly. That is an error case which can be fixed. So I think it should be an error. From my understanding, a warning should be used in the case that there is something concerning but likely there is nothing to be fixed, like profile mismatch in instrument FDO.

Just above the error reporting I added, there has already been another error handling dealing the case that a profile cannot be opened. I think these two cases are similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95269/new/

https://reviews.llvm.org/D95269