[PATCH] D95116: [NFC][PowerPC] Update PC-Relative Load/Store Patterns to use the refactored Load/Store Implementation

Baptiste Saleil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 15:44:56 PST 2021


bsaleil accepted this revision.
bsaleil added a comment.
This revision is now accepted and ready to land.

LGTM, I only have a minor comment.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:258
+    /// PC-Relative addressing mode.
+    bool SelectPCRelForm(SDNode *P, SDValue N, SDValue &Disp, SDValue &Base) {
+      return PPCLowering->SelectOptimalAddrMode(P, N, Disp, Base, *CurDAG,
----------------
Could you rename the `P` argument to `Parent` like in the other Select* functions ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95116/new/

https://reviews.llvm.org/D95116



More information about the llvm-commits mailing list