[PATCH] D94106: [Local] Treat calls that may not return as being alive (WIP).

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 15:11:19 PST 2021


jdoerfert added a comment.

Can we add something along the lines of the commit message for  D95260 <https://reviews.llvm.org/D95260>

>   In languages where infinite side-effect free loops are undefined behavior, willreturn is inferred from readnone+mustprogress by D94502. Such languages should see no regressions from this change. For languages where infinite loops are well-defined, D94633 infers willreturn for straight-line code.



In D94106#2516777 <https://reviews.llvm.org/D94106#2516777>, @nikic wrote:

> This LGTM apart from the attributor test changes -- @jdoerfert Could you please check if those make sense?

I assume you run the test update script, which should be OK. I double checked and it seems sensible, though the Attributor must be thought about this separately to avoid it removing such calls, that's on my plate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94106/new/

https://reviews.llvm.org/D94106



More information about the llvm-commits mailing list