[PATCH] D94106: [Local] Treat calls that may not return as being alive (WIP).

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 15:00:48 PST 2021


nikic added a comment.

This LGTM apart from the attributor test changes -- @jdoerfert Could you please check if those make sense?



================
Comment at: llvm/test/Transforms/InstSimplify/ConstProp/math-1.ll:16
 ; CHECK-LABEL: @f_asinf(
-; CHECK-NEXT:    ret float 0x3FF921FB{{.+}}
+; CHECK-NEXT:    ret float 0x3FF921FB60000000
 ;
----------------
The changes to math-1.ll and math-2.ll are unnecessary and probably wrong -- I assume these wildcards are there to paper over some issues in platform-dependent trig accuracy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94106/new/

https://reviews.llvm.org/D94106



More information about the llvm-commits mailing list