[PATCH] D95265: [lld-macho] Force-loading should share code path with regular archive loads

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added subscribers: steven_wu, hiraditya, mgorny.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This extends D92539: [lld-macho] Support parsing of bitcode within archives <https://reviews.llvm.org/D92539> to work even when we are loading archive
members via `-force_load`. I uncovered this issue while trying to
force-load archives containing bitcode -- we were segfaulting.

In addition to fixing the `-force_load` case, this diff also addresses
the behavior of `-ObjC` when LTO bitcode is involved -- we need to
force-load those archive members if they contain ObjC categories.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95265

Files:
  lld/MachO/CMakeLists.txt
  lld/MachO/Driver.cpp
  lld/MachO/Driver.h
  lld/MachO/DriverUtils.cpp
  lld/MachO/InputFiles.cpp
  lld/test/MachO/invalid/bad-archive-member.s
  lld/test/MachO/invalid/bad-archive.s
  lld/test/MachO/lto-archive.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95265.318641.patch
Type: text/x-patch
Size: 10142 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210122/824ca708/attachment.bin>