[PATCH] D93953: NFC: Remove simple_ilist comment mentioning ilist/iplist allocating

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 13:05:07 PST 2021


dexonsmith added a comment.

In D93953#2514784 <https://reviews.llvm.org/D93953#2514784>, @lanza wrote:

>> TBH, a little while after I fixed the UB that was causing miscompiles for us, I was pulled into other things and never got back to this. I'm certainly not working on it right now, although I'm happy to review things in this area (and maybe I'll dive back in a some point if no one else does...).
>
> Am I recalling correctly that you more or less just wanted to do a wholesale `sed 's/\(i\|p\)list/owning_ilist/g` (with a more thorough script. of course) across the code base? Or was there more to it?

Yes, that sounds right to me; I don't remember if I got around to doing an RFC, and if even I did, it probably deserves a new one (on llvm-dev). `ilist` is pretty broadly used by out-of-tree code as well as in-tree so it could be could be controversial if the churn isn't justified; IMO, a clear name is better, but an RFC would be good I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93953/new/

https://reviews.llvm.org/D93953



More information about the llvm-commits mailing list