[PATCH] D95223: [LTO] Move DisableVerify setting to LTOCodeGenerator class (NFC).

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 12:10:16 PST 2021


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with one suggestion below.



================
Comment at: llvm/include/llvm/LTO/legacy/LTOCodeGenerator.h:244
   std::unique_ptr<ToolOutputFile> StatsFile = nullptr;
+  bool DisableVerify = true;
 };
----------------
Nit - I would say make this false by default (similar to the option in llvm-lto). While it presumably should always get set by clients, false seems like a good conservative default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95223/new/

https://reviews.llvm.org/D95223



More information about the llvm-commits mailing list