[PATCH] D93912: [libc++][P1679] add string contains

[Mark de Wever via Phabricator via llvm-commits]

Mordante added a comment.

In D93912#2515767 <https://reviews.llvm.org/D93912#2515767>, @WimLeflere wrote:

> The paper is fully implemented.
>
> With the caveat that `std::string::contains` is not `constexpr` yet.
> `std::string_view::contains` is `constexpr`

Looking at the code that's only because `std::string` itself can't be used as `constexpr` yet. The patch has the proper `constexpr`.

I'll update the status page. Thanks for the information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912