[PATCH] D94944: [RISCV] Add support for rev8 and orc.b to Zbb.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 10:33:29 PST 2021


asb accepted this revision.
asb added a comment.

LGTM, and I agree with the reasoning re preferring to point users towards zbb.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:240
+    // pattern match it directly in isel.
+    setOperationAction(ISD::BSWAP, XLenVT, Subtarget.hasStdExtZbb() ? Legal
+                                                                    : Expand);
----------------
Nit: the clang-format suggested reformatting seems sensible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94944/new/

https://reviews.llvm.org/D94944



More information about the llvm-commits mailing list