[PATCH] D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF

Fri Jan 22 10:31:51 PST 2021

tmsriram added a comment.

Could you please give more details about COFF versus ELF differences with regards to

1. DebuInfo Handling - Separating out a function into a separate section requires that debug info use dwarf ranges.
2. CFI handling

if there are any.  I am not familiar with COFF. Thanks for doing this!

================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:84
 // profiles and allows optimizations such as hugepage mapping to be applied at a
 // section granularity. Defaults to ".text.split." which is recognized by lld
 // via the `-z keep-text-section-prefix` flag.
----------------
Maybe fix the comment too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95209/new/

https://reviews.llvm.org/D95209