[PATCH] D93039: Introduce llvm.noalias.decl intrinsic

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 10:22:39 PST 2021


asbirlea added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:5586
+
+    // [ItCurrent, ItNext[ represents the declarations for the same scope.
+    // Ensure they are not dominating each other
----------------
jeroen.dobbelaere wrote:
> asbirlea wrote:
> > s/[/]
> ItCurrent inclusive, ItNext exclusive.
> Or   [ ItCurrent, ItNext-1 ].
> 
Thank you for the clarification, I realized the interval from the code, but then didn't connect it to the comment notation.
This format is new to me. I was taught the mathematical notation is `[ItCurrent, ItNext)` in this case, or, as you said, `[ItCurrent, ItNext-1]`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93039/new/

https://reviews.llvm.org/D93039



More information about the llvm-commits mailing list