[PATCH] D93764: [LoopUnswitch] Implement first version of partial unswitching.

Fri Jan 22 09:59:04 PST 2021

mstorsjo added a comment.

In D93764#2515449 <https://reviews.llvm.org/D93764#2515449>, @fhahn wrote:

> In D93764#2515106 <https://reviews.llvm.org/D93764#2515106>, @mstorsjo wrote:
>
>> I've got one problem narrowed down to one source file in a project; https://martin.st/temp/dav1d-thread_task-preproc.c, compiled with `clang -target x86_64-w64-mingw32 -c -O3` does trigger the issue - I haven't dug in closer to zoom in on exactly what it is though - hopefully you can spot the differences.
>
> One issue with the file was that the patch did not account for atomic loads and would add additional atomic loads. I fixed that in 86991d323133 <https://reviews.llvm.org/rG86991d3231334538cccf6732056cbb641046bd49>. Please let me know if that fixes your issue. Otherwise I'll revert the patch to investigate further.

Thanks! I think it looks mostly good now - I'm still seeing some breakage compared to thursday, but I'll have to bisect those errors separately to see where they broke.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93764/new/

https://reviews.llvm.org/D93764