[PATCH] D95056: [CSSPGO] LTO option for pseudo probe

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Options.td:628
+def: J<"plugin-opt=pseudo-probe-for-profiling">,
+  Alias<lto_pseudo_probe_for_profiling>, HelpText<"Alias for -lto-pseudo-probe-for-profiling">;
 def: J<"plugin-opt=sample-profile=">,
----------------
` -` -> ` --`


================
Comment at: lld/ELF/Options.td:553
+def lto_pseudo_probe_for_profiling: F<"lto-pseudo-probe-for-profiling">,
+  HelpText<"Encode pseudo probes for sample profiling.">;
 def disable_verify: F<"disable-verify">;
----------------
wenlei wrote:
> hoy wrote:
> > wenlei wrote:
> > > nit: Encode -> Emit? the clang driver help messages says "Emit pseudo probes for sample profiler", would be good change to "profiling" there too.
> > Good catch, changed Encode and profiling.
> I actually meant to suggest both lld and clang driver use "Emit pseudo probes for sample profiling", the switch name uses profiling. 
Drop period


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95056/new/

https://reviews.llvm.org/D95056