[PATCH] D94857: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 09:16:14 PST 2021


JDevlieghere accepted this revision.
JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:661
+  /// with the given error code.
+  bool shouldFallBackToExternalFS(std::error_code Error) const;
+
----------------
Nit: most of the implementation uses `EC` as the variable name for an `error_code`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94857/new/

https://reviews.llvm.org/D94857



More information about the llvm-commits mailing list