[PATCH] D94501: [SelectionDAG] Support scalable-vector splats in more cases

Fri Jan 22 09:10:33 PST 2021

david-arm added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/sve-int-arith-imm.ll:598
 ; CHECK-NEXT: ret
   %elt = insertelement <vscale x 16 x i8> undef, i8 8, i32 0
   %splat = shufflevector <vscale x 16 x i8> %elt, <vscale x 16 x i8> undef, <vscale x 16 x i32> zeroinitializer
----------------
frasercrmck wrote:
> craig.topper wrote:
> > Is this test trying to test an oversized shift amount or just a bad choice of constant? I'm leaning towards bad constant choice the lsl tests don't have this issue?
> Yeah I'd imagine the latter too. I tried to tag some of the AArch64 team to see if they could help resolve this issue
Oh yeah, sorry about this. We did discuss it and the problem is with our tests I think. We've created tests that are shifting by more than the element width. I think this change is fine and we'll create some better tests after your patch lands.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94501/new/

https://reviews.llvm.org/D94501