[PATCH] D95152: [ELF] --wrap: retain __wrap_foo if foo is defined in an object/bitcode file

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 09:01:57 PST 2021


MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1930
+    // wrap sym references regardless of whether sym is defined to address
+    // https://sourceware.org/bugzilla/show_bug.cgi?id=26358 .
+    if (sym->referenced || sym->isDefined())
----------------
jhenderson wrote:
> 
. is a valid part of a URL and this will make clicking the URL broken in many systems...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95152/new/

https://reviews.llvm.org/D95152



More information about the llvm-commits mailing list