[PATCH] D95137: [update_(llc_)test_checks.py] Support pre-processing commands

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 08:30:53 PST 2021


lebedev.ri added a comment.

In D95137#2515669 <https://reviews.llvm.org/D95137#2515669>, @jrtc27 wrote:

> In D95137#2515647 <https://reviews.llvm.org/D95137#2515647>, @lebedev.ri wrote:
>
>> Is `sed` even allowed to be used in tests? Is it available in the required tool set?
>
> There are lots of uses in llvm/test/CodeGen/ for various architectures already.

Touché.
I'm uneasy about such tests, but the UpdateTestChecks is fine i guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95137/new/

https://reviews.llvm.org/D95137



More information about the llvm-commits mailing list