[PATCH] D95241: AMDGPU: Fix redundant FP spilling/assert in some functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: scott.linder, RamNalamothu, kerbowa, rampitec.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, qcolombet.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

If a function has stack objects, and a call, we require an FP. If we
did not initially have any stack objects, and only introduced them
during PrologEpilogInserter for CSR VGPR spills, SILowerSGPRSpills
would end up spilling the FP register as if it were a normal
register. This would result in an assert in a debug build, or
redundant handling of the FP register in a release build.

      

Try to predict that we will have an FP later, although this is ugly.


https://reviews.llvm.org/D95241

Files:
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/test/CodeGen/AMDGPU/gfx-callable-preserved-registers.ll
  llvm/test/CodeGen/AMDGPU/need-fp-from-csr-vgpr-spill.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95241.318531.patch
Type: text/x-patch
Size: 9032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210122/efc775b2/attachment.bin>