[PATCH] D94766: Add lit env variable to disable indirect checks

Fri Jan 22 07:42:09 PST 2021

jdenny added a comment.

In D94766#2515070 <https://reviews.llvm.org/D94766#2515070>, @thopre wrote:

> But as I said, no need to talk about my specifics, I can find a workaround if needed.

Well, it's the only example I have so far.  But we seem to be converging on another solution now.

> Just looking at lit usage message, I could see most option making sense as a config option.

For me, it's just the opposite.  Most seem like they are not properties of a test suite that belong in the config.  Most seem like they are specific to a run of the test suite.

> I don't personally need them though.  I guess a config option of --no-indirect-run-check is enough and can be generalized later.

That's fine.  But I am curious to hear more about the general use case.  If it's useful, it will probably come up again.

>> Actually, it seems to me that `--no-indirect-run-check` probably should have been a lit config option in the first place.  It declares a property of the test suite: it has legitimate tests that are only run individually.  lit invocations shouldn't have to declare that again and again.  Or have I misunderstood the use case?
>
> No that makes sense. A config option would work for me. Should I make a new patch to that effect then?

Ignoring backward-compatibility, would the command-line option then be unnecessary?  Whether we remove it immediately is a different question.

Before you invest time in this, it might be good to hear from someone else.  @yln, does this solution seem reasonable to you?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94766/new/

https://reviews.llvm.org/D94766