[PATCH] D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I'll land this on Monday, as I'm coming to the end of my workday now.



================
Comment at: lld/test/ELF/tls-weak-undef.s:12
+
+## A weak symbol does not fetch a lazy definition.
+# RUN: ld.lld %texec.o --start-lib %tdef.o --end-lib -o %tlazy
----------------
MaskRay wrote:
> A TLS undefined weak symbol
> 
> undefined is important.
> TLS as a modifier is also useful.
I've gone with "An undefined weak TLS symbol" as I feel like it reads nicer.


================
Comment at: lld/test/ELF/tls-weak-undef.s:24
+# RUN: ld.lld -shared %tdef.o -o %tdef.so
+# RUN: not ld.lld %texec.o %tdef.so -o /dev/null 2>&1 | FileCheck --check-prefix=COPYRELOC %s
+
----------------
MaskRay wrote:
> Copy relocations are specific to executables. I think COPYRELOC may be misguiding.
`COPYRELOC` was the name in the pre-existing test my change is essentially updating. I'm not particularly familiar with this aspect of code. I'll go with `ERROR` since it's testing the error message, unless anybody else has got a better suggestion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95124/new/

https://reviews.llvm.org/D95124