[PATCH] D95216: [AMDGPU][MC] Refactored exp tgt handling

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 06:11:56 PST 2021


dp added a comment.

In D95216#2515318 <https://reviews.llvm.org/D95216#2515318>, @foad wrote:

>> Separated tgt encoding from parsing;
>> Separated tgt decoding from printing;
>
> Is there a reason for this? Do you want to use the encoding/decoding logic from somewhere else?

No, this is an attempt to make code more manageable. I believe that encoding/decoding logic should be in one place rather than split between parser and instruction printer. I think that most encoding/decoding logic have already been moved to AMDGPUBaseInfo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95216/new/

https://reviews.llvm.org/D95216



More information about the llvm-commits mailing list