[PATCH] D94912: [llvm-nm][ELF] - Use @@ prefix when printing default versions.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 03:57:29 PST 2021


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1689
 
+namespace {
+
----------------
grimar wrote:
> jhenderson wrote:
> > I was under the impression that anonymous namespaces were purely for hiding structs and classes, and not functions, based on the coding standards?
> True (https://llvm.org/docs/CodingStandards.html#anonymous-namespaces). Fixed.
Posted this a bit too early. Will be fixed in update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94912/new/

https://reviews.llvm.org/D94912



More information about the llvm-commits mailing list