[PATCH] D95219: [libObject,llvm-readelf/obj] - Don't use @@ when printing versions of undefined symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 03:28:55 PST 2021


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
grimar requested review of this revision.
Herald added a project: LLVM.

A default version (@@) is only available for defined symbols.
Here is a corresponding code from GNU readelf:

    if (sym_info == symbol_undefined)
      printf ("@%s (%d)", version_string, vna_other);
    else
      printf (sym_info == symbol_hidden ? "@%s" : "@@%s",
  	    version_string);

Currently we use "@@" for undefined symbols too.
This patch fixes the issue and improves our test case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95219

Files:
  lld/test/ELF/partition-synthetic-sections.s
  llvm/include/llvm/Object/ELF.h
  llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
  llvm/test/tools/llvm-readobj/ELF/versioninfo.test
  llvm/tools/llvm-nm/llvm-nm.cpp
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95219.318478.patch
Type: text/x-patch
Size: 20676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210122/d0d1fccc/attachment.bin>


More information about the llvm-commits mailing list