[PATCH] D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse

Fri Jan 22 03:25:57 PST 2021

paulwalker-arm added a comment.

In D94883#2512892 <https://reviews.llvm.org/D94883#2512892>, @david-arm wrote:

> In D94883#2512711 <https://reviews.llvm.org/D94883#2512711>, @fhahn wrote:
>
>> Mirroring my comments for D94708 <https://reviews.llvm.org/D94708>: if the intrinsics needs to support fixed vectors, it would be good to have some  tests for platforms other than AArch64 and also support in GlobalISel, which is the default on AArch64 with `-O0` IIRC (or do the transform to shuffles as an IR transform).
>
> Hi @fhahn, I agree with your point about -O0, but I'm not sure why we need tests for other platforms? Carol has an extensive set of tests for both fixed width and scalable vectors. The lowering is identical for fixed width vectors regardless of the target so all it would be testing is the different codegen of vector shuffles.

I agree, such extra tests seem wasteful as I'd expect ISD::VECTOR_SHUFFLE to already be sufficiently tested for all targets.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94883/new/

https://reviews.llvm.org/D94883