[PATCH] D95140: [yaml2obj, obj2yaml] - Implement section header table as a special Chunk.

Fri Jan 22 01:49:27 PST 2021

jhenderson added a comment.

In D95140#2514933 <https://reviews.llvm.org/D95140#2514933>, @grimar wrote:

> In D95140#2514914 <https://reviews.llvm.org/D95140#2514914>, @jhenderson wrote:
>
>> It feels like there needs to be testing there for writing the section header table in the right place in the YAML (with Offset if needed), but I don't see that yet.
>
> It is not yet implemented. Currently obj2yaml can only emit the section header chunk at the end of the sections list (when the order of sections doesn't match the order in the section header table).
> I supposed we can implement the dumping at a proper position in a follow-up(s). Does it sound OK for you?

I suspected that was the case, but wasn't sure, so deferring is fine.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95140/new/

https://reviews.llvm.org/D95140