[PATCH] D95152: [ELF] --wrap: retain __wrap_foo if foo is defined in an object/bitcode file

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Apart from a couple of nits, I'll leave reviewing this to @andrewng, since I know he's looked into the issue more (he and I work together).



================
Comment at: lld/ELF/Driver.cpp:1930
+    // wrap sym references regardless of whether sym is defined to address
+    // https://sourceware.org/bugzilla/show_bug.cgi?id=26358 .
+    if (sym->referenced || sym->isDefined())
----------------



================
Comment at: lld/ELF/Options.td:476
 
-defm wrap: Eq<"wrap", "Use wrapper functions for symbol">,
+defm wrap: Eq<"wrap", "Redirect symbol references to __wrap_symbol and __real_symbol references to symbol">,
   MetaVarName<"<symbol>">;
----------------
This line looks quite long?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95152/new/

https://reviews.llvm.org/D95152