[PATCH] D85882: [AMDGPU] Update subtarget features for new target ID support
Austin Kerbow via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 21 23:18:18 PST 2021
kerbowa added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:169-172
+ LLVM_DEBUG(dbgs() << "xnack setting for subtarget: "
+ << TargetID.getXnackSetting() << '\n');
+ LLVM_DEBUG(dbgs() << "sramecc setting for subtarget: "
+ << TargetID.getSramEccSetting() << '\n');
----------------
arsenm wrote:
> I think having debug printing in the subtarget constructor would be a net annoyance
We already had debug printouts in the constructor from ParseSubtargetFeatures. Do you think they should all be removed? Right now the output with '-debug-only=amdgpu-subtarget' looks like this, which seems helpful to me.
```
Features:+promote-alloca,+load-store-opt,+enable-ds128,+enable-prt-strict-null,
CPU:gfx900
TuneCPU:gfx900
xnack setting for subtarget: Any
sramecc setting for subtarget: Unsupported
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85882/new/
https://reviews.llvm.org/D85882
More information about the llvm-commits
mailing list