[PATCH] D94907: [llvm-nm][ELF] - Make -D display symbol versions.

Thu Jan 21 23:13:58 PST 2021

grimar added inline comments.

================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1831
+      if (!SymbolVersions.empty() && !SymbolVersions[I].empty())
+        S.Name += "@" + SymbolVersions[I];
+
----------------
MaskRay wrote:
> MaskRay wrote:
> > Sorry, I did not read carefully.
> > 
> > This is wrong. D94912 should just be folded into D94907. We should not have pushed D94907 leaving @ in the output where the correct output uses `@@` and the legacy output does not use @ at all.
> This caused https://github.com/ClangBuiltLinux/linux/issues/1266 @nathanchance 
> 
> Though it is probably not too urgent.
I was under impression that GNU nm never prints `@@`. But seems it just doesn't do it for undefined symbols, and I guess I didn't try other cases previously.
Anyways I am going to look into this issue today.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94907/new/

https://reviews.llvm.org/D94907