[PATCH] D94907: [llvm-nm][ELF] - Make -D display symbol versions.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 21:48:52 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1831
+      if (!SymbolVersions.empty() && !SymbolVersions[I].empty())
+        S.Name += "@" + SymbolVersions[I];
+
----------------
Sorry, I did not read carefully.

This is wrong. D94912 should just be folded into D94907. We should not have pushed D94907 leaving @ in the output where the correct output uses `@@` and the legacy output does not use @ at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94907/new/

https://reviews.llvm.org/D94907



More information about the llvm-commits mailing list