[PATCH] D92069: [NFC] [TargetRegisterInfo] add one use check to lookThruCopyLike.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 17:41:42 PST 2021


shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetRegisterInfo.cpp:536
 
+Register TargetRegisterInfo::lookThruSingleUseCopyChain(
+    Register SrcReg, const MachineRegisterInfo *MRI) const {
----------------
echristo wrote:
> You should document what it's doing ahead of time as well. It's not clear when and how you'd use this function.
Thank you, @echristo . Do you think is it ok to add
```
This function is called when try to delete the root non-copy virtual register. We must make sure the root non-copy virtual register and all the copy like definitions in the chain have only one user.
```
In the header?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92069/new/

https://reviews.llvm.org/D92069



More information about the llvm-commits mailing list