[PATCH] D95186: [Inlining] Delete redundant optnone/alwaysinline check

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 17:08:09 PST 2021


lxfind added a comment.

In D95186#2514080 <https://reviews.llvm.org/D95186#2514080>, @wenlei wrote:

>> The same check is done in InlineCost: https://github.com/llvm/llvm-project/blob/8b0bd54d0ec968df28ccc58bbb537a7b7c074ef2/llvm/lib/Analysis/InlineCost.cpp#L2537-L2552
>
> The check in InlineCost is on Caller, so it's not strictly redundant.

It checks both there:

  if (Call.hasFnAttr(Attribute::AlwaysInline)) ...
  ...
  if (Caller->hasOptNone())


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95186/new/

https://reviews.llvm.org/D95186



More information about the llvm-commits mailing list