[PATCH] D93529: [AA] Store and return estimated PartialAlias offsets.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea requested changes to this revision.
asbirlea added a comment.
This revision now requires changes to proceed.

Adding this only seems to make sense when using BatchAA.
Could we restrict populating this cache? e.g. extend AAQueryInfo constructor to take `bool BatchMode = false`, and set it to true for BatchAA. Then update the get/set methods to first check this (check in the setter and assert in the getter).



================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:360
 
+  using OffsetPair = std::pair<const Value *, const Value *>;
+  using OffsetsCacheT = SmallDenseMap<OffsetPair, int64_t, 8>;
----------------
Document (add comments) what this cache stores, and its purpose.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:1205
+            Off.ule(INT64_MAX)) {
+          // Memory refernced by right pointer is nested. Save the offset in
+          // cache.
----------------
`referenced`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93529/new/

https://reviews.llvm.org/D93529