[PATCH] D94334: [InlineAdvisor] Allow replay of inline decisions for the CGSCC inliner from optimization remarks

Di Mo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 15:54:54 PST 2021


modimo updated this revision to Diff 318339.
modimo added a comment.

Wrap ReplayInlineAdvisor into InlineAdvisor so that we can fall back to the original Advisor if we don't want to follow the replay. I think the composition of advisors here makes sense but I'm not sure so I'm very open to different approaches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94334/new/

https://reviews.llvm.org/D94334

Files:
  llvm/include/llvm/Analysis/InlineAdvisor.h
  llvm/include/llvm/Transforms/IPO/Inliner.h
  llvm/lib/Analysis/InlineAdvisor.cpp
  llvm/lib/Transforms/IPO/Inliner.cpp
  llvm/test/Transforms/Inline/Inputs/cgscc-inline-replay.txt
  llvm/test/Transforms/Inline/cgscc-inline-replay.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94334.318339.patch
Type: text/x-patch
Size: 9985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210121/726dd327/attachment.bin>


More information about the llvm-commits mailing list