[PATCH] D95004: [PowerPC] Add missing negate for VPERMXOR on little endian subtargets

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 15:41:53 PST 2021


amyk accepted this revision as: amyk.
amyk added a comment.

Also LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2426
+// the intrinsic (but only for little endian system).
+let Predicates = [HasVSX, IsLittleEndian, HasP8Altivec] in
+  def : Pat<(v16i8 (int_ppc_altivec_crypto_vpermxor v16i8:$a,
----------------
nit: Maybe add the new predicates in the `Predicate combinations available` comment? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95004/new/

https://reviews.llvm.org/D95004



More information about the llvm-commits mailing list