[PATCH] D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.

lgtm, thanks!



================
Comment at: llvm/test/tools/llvm-profgen/recursion-compression.test:1
+; Firstly test uncompression(--compress-recursion=0)
+; RUN: llvm-profgen --perfscript=%S/Inputs/recursion-compression.perfscript --binary=%S/Inputs/recursion-compression.perfbin --output=%t --compress-recursion=0
----------------
wlei wrote:
> wenlei wrote:
> > wlei wrote:
> > > wenlei wrote:
> > > > A test case to cover line-based profile too? That goes through slightly different path for handling the inline context expansion, so e2e test would be good (doesn't have to be as through as the one for probe though).
> > > Good catch, the line-based test added
> > Test for `--compress-recursion=0` is gone? and I don't see new test case here? 
> Oh, I guess you need to refer the latest commit. I removed this file, so the code here is outdated.
Oops.. sorry i was indeed looking at the wrong version.  thanks for adding test for line-based profile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93556/new/

https://reviews.llvm.org/D93556